Jean-Marc Lasgouttes wrote:
> >>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]>
> >>>>> writes:
>
> Juergen> The problem is that the changes need to be applied before
> Juergen> running LFUN_LAYOUT_SAVE_DEFAULT. How can we do that? One
> Juergen> solution would be to pop up a question if there are
> unapplied Juergen> changes when pressing the "Save as Default"
> button: "You have Juergen> to apply your settings before they can be
> saved as class Juergen> default. Do you want to apply them now?" This
> could be Juergen> annoying since we have two popups in this saving
> process Juergen> then. Are there better solutions?
>
> This is what I outlined in a previous message. We have to change the
> apply methods to take a BufferParams parameter, so that one can do
> apply without changing the document. For some of these, this is easy
> (for example paper_apply(), although Buffer::setPaperStuff should be
> moved to BufferParams, where it belongs), but it _may_ be trickier
> for others. For example, the code which translates documents when
> textclass has been changed should not be there.
Yes, I remember now. Thanks for reminding!
> So I propose to have the xxx_apply(BufferParams &) which does stuff
> which apply only to buffer->params(), and then have
>
> void xxx_apply()
> {
> xxx_apply(lv_->buffer()->params);
> //do other stuff here
> }
>
> Do you feel like trying to do that?
At the moment, my time is very limited (my PhD needs some urgent
updates and bugfixes ;-), and there are still the tabular dialog
changes on my list (yet undone). If you don't want to wait and find
some time to do it, please feel free to go, otherwise I may have a try,
note: "try", since this is very new stuff to me.
Thanks,
Jürgen.
> JMarc
