>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> I had a closer look. I think I tried all possible settings,
Juergen> saved as class default and reopended. Seems that it works now
Juergen> as it should. Very good work.
Fine. A remaining problem: 'save class defaults' is not a good name,
since it looks like 'reset class defaults'. A better name would be
'save default document layout' or 'save as defaults for new
documents', but these are of course too long. This buttons operates on
_all_ parameters in the popup, not only class defaults (which are the
defaults of the class as defined in the layout file). Could you find a
better name?
Juergen> The only thing that became worse AFAICS is the "Use Class
Juergen> Defaults" button. It is now disabled most of the time
Juergen> (actually it obviously disables after any first change you
Juergen> do), which shouldn't happen. Is it possible that
Juergen> params.hasClassDefaults() doesn't give the correct values
Juergen> anymore?
First problem:
- in FormDocument::input
setEnabled(dialog_->button_reset_defaults,
lv_->buffer()->params.hasClassDefaults());
should be
setEnabled(dialog_->button_reset_defaults,
!lv_->buffer()->params.hasClassDefaults());
- as you can see in code above, you compare to the actual buffer
parameters (i.e. after an "apply"). If you really want the current
popup state, you should do an apply on a BufferParams variable, and
use this one in the test. I do not think this will be too expensive
in terms of time.
AFAIK, none of these problems are related to my changes.
JMarc
PS: if you are looking at more things to to on popups, I have a
project for you: adding shortcuts to popups. I think it would be a
rather safe change, and some people have shown interest in this.
