On Mon, Apr 14, 2025 at 04:21:18PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/04/2025 à 15:35, Scott Kostyshak a écrit : > > > > JMarc, can you confirm this removal is OK? If it is in there, then I > > get the following: > > > > In file included from BufferView.cpp:82: > > ./support/pmprof.h:121:2: error: Profiling is not usable when run-time > > debugging is in effect > > 121 | #error Profiling is not usable when run-time debugging is in effect > > | ^ > > Yes, sure. It seems you are the only one using stdlib-debug, it is good that > you do it.
I remember it found an issue a while ago. I don't know how useful it is but it doesn't seem to affect performance much for my use cases so I think I'll keep it, and just disable when I want to use PMPROF. > > By the way, that error is very informative. Thanks for having it in there. > > I should catch stdlib assertions too (and lic++ too). > > > There is still the following in GuiFontMetrics.cpp: > > > > #define DISABLE_PMPROF > > #include "support/pmprof.h" > > > > I don't know why this doesn't trigger the error. > > Because of the DISABLE above. This allows to keep the instrumentation > (PROFILE_THIS_BLOCK) in the code, but make it inert. Ah that is very nice. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
