On Mon, Apr 14, 2025 at 01:30:07PM +0000, Scott Kostyshak wrote:
> commit 74ef4e4d2535cad56defdd374f4d880f995926ee
> Author: Scott Kostyshak <skost...@lyx.org>
> Date:   Mon Apr 14 15:26:31 2025 +0200
> 
>     Remove a profiling header
> ---
>  src/BufferView.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/BufferView.cpp b/src/BufferView.cpp
> index 71ca2faebf..3748c7166d 100644
> --- a/src/BufferView.cpp
> +++ b/src/BufferView.cpp
> @@ -80,7 +80,6 @@
>  #include "support/Lexer.h"
>  #include "support/lstrings.h"
>  #include "support/lyxlib.h"
> -#include "support/pmprof.h"
>  #include "support/types.h"
>  
>  #include <algorithm>
> -- 
> lyx-cvs mailing list
> lyx-...@lists.lyx.org
> https://lists.lyx.org/mailman/listinfo/lyx-cvs

JMarc, can you confirm this removal is OK? If it is in there, then I
get the following:

In file included from BufferView.cpp:82:
./support/pmprof.h:121:2: error: Profiling is not usable when run-time 
debugging is in effect
  121 | #error Profiling is not usable when run-time debugging is in effect
      |  ^

By the way, that error is very informative. Thanks for having it in there.

I am fine to remove the debug flags instead if you prefer to keep the
header.

There is still the following in GuiFontMetrics.cpp:

#define DISABLE_PMPROF
#include "support/pmprof.h"

I don't know why this doesn't trigger the error.

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to