On Mon, Mar 10, 2025 at 11:54:06AM -0400, Richard Kimberly Heck wrote: > > On Mon, Mar 10, 2025 at 10:55:31AM +0100, Pavel Sanda wrote: > > src/frontends/qt/GuiApplication.cpp:#include <QFileInfo> > > src/frontends/qt/GuiApplication.cpp: QFileInfo > > fi(uifiles[i]); > > src/frontends/qt/GuiDocument.cpp: QString fn = > > QFileInfo(it.next()).fileName(); > > src/frontends/qt/GuiLyXFiles.cpp: QFileInfo const info = > > QFileInfo(it.key()); > > src/frontends/qt/GuiPrefs.cpp:#include <QFileInfo> > > src/frontends/qt/GuiTabularCreate.cpp: QString fn = > > QFileInfo(it.next()).fileName();
All these seem actually as fair use at it's inside Qt related manipulations where we would ba just adding fromqstr / toqstr around to get FileName. > > src/support/TempFile.cpp:#include <QFileInfo> > > src/support/TempFile.cpp: QFileInfo > > tmp_fi(QDir(toqstr(temp_dir.absoluteFilePath())), > > src/support/TempFile.cpp: QFileInfo > > tmp_fi(QDir(toqstr(package().temp_dir().absoluteFilePath())), > > src/support/filetools.cpp: QFileInfo > > tmp_fi(QDir(toqstr(tempdir.absFileName())), toqstr(mask)); These are more borderline, but still reasonable use, as they use specifics (like constructor calls) not provided by FileName itself. So I left things as they are now. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
