On Sat, Mar 08, 2025 at 12:19:49PM +0000, Koji Yokota wrote:
> commit c9bcceadb03e9826e36ff8b81a5ba5daaa0c3fa6
> Author: Koji Yokota <yok...@lyx.org>
> Date:   Fri Mar 7 13:57:09 2025 +0900
> 
>     Fix theme import function
> ---
>  src/frontends/qt/GuiPrefs.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/frontends/qt/GuiPrefs.cpp b/src/frontends/qt/GuiPrefs.cpp
> index 7558235822..adbcf4094a 100644
> --- a/src/frontends/qt/GuiPrefs.cpp
> +++ b/src/frontends/qt/GuiPrefs.cpp
> @@ -59,6 +59,7 @@
>  #include <QAbstractItemModel>
>  #include <QCheckBox>
>  #include <QFile>
> +#include <QFileInfo>

Koji, are you aware that we have support/FileName.h/cpp?
I did not check carefully all your operations, but I suspect
all your filename needs are pretty much covered by this header?

I think it would be better to stick to one only API so weird
bugs we already encountered with QFile/info in past can be handled
in one central place.


> +     // compy to user theme dir

"copy" ?

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to