Re: [PATCH] os class for OS/2 & Win32 support final version

[Jean-Marc Lasgouttes]

>>>>> "Ruurd" == Ruurd A Reitsma <[EMAIL PROTECTED]> writes:

Ruurd> Here's the final (?) version of my win32 patch. Details are in
Ruurd> the README.Win32. I've also attatched a patch for the 116
Ruurd> branch.

This looks good to me. I'd rather not apply it to 1.1.6, but it is IMO
OK for 1.2.0. A few random remarks

- please reformat README.Win32 to 80 columns
- instead of giving your lyxwin32 program in this file, you could
  bundle it separately in development/
- a small comment could be useful for the X_OK define in FileInfo.h
- remove completely CleanupPath in filetools.h
- in lyx::rename, it would be better to use lyx::unlink rather than
  ::unlink. 

JMarc