On Tue, Mar 29, 2022 at 07:28:37PM +0200, Pavel Sanda wrote:
> On Tue, Mar 29, 2022 at 07:54:31AM -0400, Scott Kostyshak wrote:
> > On Tue, Mar 29, 2022 at 01:33:32PM +0200, Pavel Sanda wrote:
> > > On Mon, Mar 28, 2022 at 07:52:33PM -0400, Scott Kostyshak wrote:
> > > > > Is this intended? How do I open all activated branch insets now?
> > > > 
> > > > I don't know if we have that functionality. Not sure it helps, but to
> > > > open all branch insets of "my-branch-name":
> > > > 
> > > >   inset-forall Branch:my-branch-name inset-toggle open
> > > > 
> > > > And to close:
> > > > 
> > > >   inset-forall Branch:my-branch-name inset-toggle close
> > > > 
> > > > Assuming the above doesn't satisfy your workflow, then we should make a
> > > > new LFUN that handles branch insets according to whether they are
> > > > activated.
> > > 
> > > To have an option to open/close them all would be helpful.
> > > I don't push for the automatic toggling we used to have but some
> > > way how to chage that through UI would be helpful.
> > > What would be UI way which wouldn't disturb you?
> > 
> > I guess in Document > Settings > Branches? 
> 
> First I thought it's good idea, but if I added button for toggling
> with your lfun, it would be triggered immediately instead after
> confirming dialog. Or one would need new params just for this which
> feels we are stretching things too far..
> 
> > and/or in the context menu when right-clicking on a branch?
> 
> The attached patch solves the problem for me.
> I would like to get at least the lfun to the master (I can add note about 
> this 
> lfun for binding to tutorial). Objections?

I find "selected branch" confusing in the documentation. It makes it
seem we should select the branch and then run the LFUN. Should we say
explicitly "the branch in front of the cursor" ? I didn't look at
similar functions so perhaps "selected x" is indeed consistent with
others. If so, please ignore.

Also, in the context menu, "toggle all" could be a little confusing. The
user might think about toggling the active status, which doesn't make
much sense, but I wonder if we might as well say "toggle all open/close" ?

> If you like I can add the entry to the context menu of branch inset (part of 
> the
> current patch), but I am equivalently happy to have in just in my private
> patchset.

Perhaps ask on lyx-users? I find it strange to *toggle*. Why do you want
to toggle rather than just "open all" or "close all" ? Can you describe
a specific use case to toggle rather than open all or close all? Perhaps
you are trying to be considerate of not taking up too many options?

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to