On Sun, Nov 22, 2020 at 10:04:40AM +0100, Yu Jin wrote:
> With fullscreen you mean View -> Fullscreen I assume? I have attached 2
> screenshots, there are still frames on the right and on the bottom after
> your commit, but tbh it doesn't bother me at all. 

So the new version is better, although it could be still improved.
Difficult to test here, but you could play with decreasing the margin
values even more (but I am not pushing it, up to you).

> Btw why didn't you use
> e.g.
> #if QT_VERSION > QT_VERSION_CHECK(5,10,1)
> for better readability?

It's just habit I took from our own code. Feel free to change.

Thanks for testing,
Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to