Am So., 22. Nov. 2020 um 00:59 Uhr schrieb Richard Kimberly Heck <
rikih...@lyx.org>:
> On 11/21/20 12:08 PM, Pavel Sanda wrote:
> > On Sat, Nov 21, 2020 at 05:24:34PM +0100, Stephan Witt wrote:
> >>>>> until (at least) Qt 5.7.1 fullscreen was over the whole screen, in
> newer Qt
> >>>>> (tested 5.11.3) there is now two bright pixel frame around (well
> visible and
> >>>>> annoying if you use dark color schemes). This is because the former
> workaround
> >>>>> trick with setContentsMargins(-2, -2, -2, -2); in fullscreen handler
> (or
> >>>>> ui-toggle frame lfun) does not work anymore and negative values are
> not
> >>>>> accepted now.
> >>>>>
> >>>>> The margin might be coming from some child widget of QMainWindow, I
> just dont
> >>>>> know which one. Anyone has idea how to fix that?
> >>>> The following patch fixes the problem.
> >>>> Stephan/Yu can you test whether I did not break fullscreen border on
> mac/windows?
>
With fullscreen you mean View -> Fullscreen I assume? I have attached 2
screenshots, there are still frames on the right and on the bottom after
your commit, but tbh it doesn't bother me at all. Btw why didn't you use
e.g.
#if QT_VERSION > QT_VERSION_CHECK(5,10,1)
for better readability?
> >>> It's in now, still waiting for Stephen/Yu feedback.
> >>> Pavel
> >> IMO you didn???t break fullscreen border. Here on Mac it looks normal.
> > Good, thanks.
> >
> > Riki, this should go to branch, up to you whether 2.3.6 or 2.3.7.
>
> Go ahead for 2.3.6.
>
--
Eugene
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
