On Wed, Jul 24, 2019 at 07:47:37PM -0600, Joel Kulesza wrote: > Tested on macOS 10.14.5 and git 2.22.0. Steps to reproduce: > > 1. Create new directory (e.g., ~/tmp/lyx_git_test), initialize git > repository, add initial commit (e.g., with a README.md file). > 2. Launch LyX 2.4.0dev (master@7bdaa2fe). > 3. File -> New Document. > 4. File -> Save As... -> test.lyx in previously created directory. > 5. Exit LyX. > 6. Add LyX file to git tracking (git add, git commit). > 7. Relaunch LyX; open test.lyx (should show "GIT" in status bar). > 8. Insert -> Field -> Other -> Version Control Information -> Revision > (works). > 9. Insert -> Field -> Other -> Version Control Information -> Tree > revision (fails with attached). > > I imagine Tree revision is invalid in this context. However, the error > printed to the console (arrowed in the attached) is probably what should be > shown in the dialog rather than what is (or perhaps the line 2 previous). > > Please contact me with any comments, questions, or concerns. Further, > please let me know if I should enter this in the tracker and to whom to > assign it.
Ok, now I see what you mean. It's the tree revision causing problems. This is actually question what do we want to call 'Tree revision'. The origin of this field comes from SVN where version of file and other files in the tree could be different, something not known in git world. I decided long time ago, that better than leaving it unimplemented for git or duplicate of file revision info (essentially HEAD) we use it for tag. There is no reason why to issue error dialog, but stating in the field "unknown" should be enough. I'll commit the fix. Pavel
