Le 28/06/2019 à 09:48, Kornel Benko a écrit :
Am Donnerstag, 27. Juni 2019, 23:24:31 CEST schrieb Jean-Marc Lasgouttes:
Le 13/06/2019 à 09:18, Kornel Benko a écrit :
commit 6f2cd26103d0d59fd76184fd76af89cb8817ad4f
Author: Kornel Benko <kor...@lyx.org>
Date: Thu Jun 13 09:18:40 2019 +0200
Cmake build:Amend 44bbd0b0 and 22f59925
Hi Kornel,
Since we have not decided to remove support for boost::regex yet in
§2.4.0dev, I think this patch should be mostly reverted.
Minimal gcc version is 4.7 (aka working c++11 except regexp)
I am not event sure we need a minimal MSVC version, but I know that the
2015 version I use now works well.
And what is the version number of this compiler, so that we could tests?
message(STATUS "MSVC_VERSION=${MSVC_VERSION}")
I do not have it here, but it is in the 1900 series (depends on the
patch level).
Now I googled for VS std::regex issues and I found this:
https://github.com/docopt/docopt.cpp/issues/67
https://github.com/docopt/docopt.cpp/issues/49
It seems that the VS regex implementation is not of great quality anyway
and that some apparently simple regexes (but with nested quantifiers)
overflow the stack. The MS engineers in their bug reports (not available
anymore) seem to acknowledge that their regex implementation is not that
good.
The interesting thing is that the bug reports quoted above say that
boost::regex is better than the other regex implementation, and faster
too. Do you see this in your advanced F&R tests?
JMarc
