On 2019-01-16, Scott Kostyshak wrote:
> [-- Type: text/plain, Encoding: quoted-printable --]
> On Tue, Jan 15, 2019 at 07:59:44PM +0100, Kornel Benko wrote:
>> Am Dienstag, 15. Januar 2019 12:42:04 CET schrieb Scott Kostyshak
>> <skost...@lyx.org>:
>> > On Tue, Jan 15, 2019 at 05:08:12PM +0000, Guenter Milde wrote:
>> > > On 2019-01-14, Scott Kostyshak wrote:
>> > >
>> > > > [-- Type: text/plain, Encoding: quoted-printable --]
>> > >
>> > > > On Sun, Feb 04, 2018 at 01:02:56PM +0100, Günter Milde wrote:
>> > > >> commit 2b451f01f50cf4f69200f2cd5ec646b1917156c1
>> > > >> Author: Günter Milde <mi...@lyx.org>
>> > > >> Date: Sun Feb 4 10:16:54 2018 +0100
>> > >
>> > > >> Add newlines around \backslash in put_cmd_in_ert.
>> > >
>> > > >> Fix for 2fce4d49ee.
>> > > >> ---
>> > > >> lib/lyx2lyx/lyx2lyx_tools.py | 2 +-
>> > > >> lib/lyx2lyx/test_lyx2lyx_tools.py | 23 +++++++++++++----------
>> > > >> 2 files changed, 14 insertions(+), 11 deletions(-)
>> > >
>> > > > This commit caused a regression:
>> > >
>> > > > $ lyx -e lyx16x lib/examples/modernCV.lyx && lyx bisect -e lyx16x
>> > > > lib/examples/modernCV.16.lyx
>> > >
>> > > > Text.cpp (1876): Handling unknown body token: `\begin_inset'
>> > > > Text.cpp (1876): Handling unknown body token: `ERT'
>> > > > Text.cpp (1876): Handling unknown body token: `status collapsed'
>> > > > Paragraph ended in line 405
>> > > > Missing \end_layout.
>> > > > Error: Document format failure
>> > > > ----------------------------------------
>> > > > /tmp/lyx_tmpdir.pILgoDU12807/Buffer_convertLyXFormatB12807.lyx ended
>> > > > unexpectedly, which means that it is probably corrupted.
>> > > > LyX failed to load the following file:
>> > > > /home/scott/lyxbuilds/bisect/repo/lib/examples/modernCV.16.lyx
>> > >
>> > > I found the reason: an "\end_inset" that moved behind the next
>> > > \begin_inset.
>> > >
>> > > Could you try the patch below?
>> > >
>> > > It solves a minimal example contrieved out of modernCV but may have
>> > > adverse side effects on other tests.
>> >
>> > Thanks for taking a look and for the patch, Günter. I will run the tests
>> > over night with your patch. Should I also use the patch you propose on
>> > the beamer thread when I run the tests?
>> >
>> > Scott
>> >
>> Patch applied ...
>> The test for
>> $ ctest -R modernCV
>> leads to
>> 3733 - export/examples/modernCV_lyx16 (Failed)
>> 4956 - export/examples/es/modernCV_lyx16 (Failed)
> I get the same.
However, the reason is a different one, the file modernCV.16.lyx is
valid (loads without error) but is still broken (does not compile).
The address line is mangled:
In modernCV.lyx exports to LaTeX
\address{Teststreet~17}{03333~Nicecity}{Switzerland}
while modernCV.16.lyx exports
\address{03333~Nicecity}{}{Teststreet~17}{Switzerland}
a) the order of city and street is swapped (because in the lyx file,
"city" is argument 1, preceded by "street" in ERT
b) there is an additional pari of "{}", which leads to compilation errors
because the \address macro takes up to 3 tokens, the 4th becomes regular
text which is not allowed before \begin{document}.
If there are no regressions for other lyx2lyx test, I will commit both
patches.
Thanks,
Günter
