Re: [LyX/master] Add newlines around \backslash in put_cmd_in_ert.

[Kornel Benko]

Am Dienstag, 15. Januar 2019 12:42:04 CET schrieb Scott Kostyshak 
<skost...@lyx.org>:
> On Tue, Jan 15, 2019 at 05:08:12PM +0000, Guenter Milde wrote:
> > On 2019-01-14, Scott Kostyshak wrote:
> > 
> > > [-- Type: text/plain, Encoding: quoted-printable --]
> > 
> > > On Sun, Feb 04, 2018 at 01:02:56PM +0100, Günter Milde wrote:
> > >> commit 2b451f01f50cf4f69200f2cd5ec646b1917156c1
> > >> Author: Günter Milde <mi...@lyx.org>
> > >> Date:   Sun Feb 4 10:16:54 2018 +0100
> > 
> > >>     Add newlines around \backslash in put_cmd_in_ert.
> > 
> > >>     Fix for 2fce4d49ee.
> > >> ---
> > >>  lib/lyx2lyx/lyx2lyx_tools.py      |    2 +-
> > >>  lib/lyx2lyx/test_lyx2lyx_tools.py |   23 +++++++++++++----------
> > >>  2 files changed, 14 insertions(+), 11 deletions(-)
> > 
> > > This commit caused a regression:
> > 
> > >   $ lyx -e lyx16x lib/examples/modernCV.lyx && lyx bisect -e lyx16x 
> > > lib/examples/modernCV.16.lyx
> > 
> > >   Text.cpp (1876): Handling unknown body token: `\begin_inset'
> > >   Text.cpp (1876): Handling unknown body token: `ERT'
> > >   Text.cpp (1876): Handling unknown body token: `status collapsed'
> > >   Paragraph ended in line 405
> > >   Missing \end_layout.
> > >   Error: Document format failure
> > >   ----------------------------------------
> > >   /tmp/lyx_tmpdir.pILgoDU12807/Buffer_convertLyXFormatB12807.lyx ended 
> > > unexpectedly, which means that it is probably corrupted.
> > >   LyX failed to load the following file: 
> > > /home/scott/lyxbuilds/bisect/repo/lib/examples/modernCV.16.lyx
> > 
> > I found the reason: an "\end_inset" that moved behind the next \begin_inset.
> > 
> > Could you try the patch below?
> > 
> > It solves a minimal example contrieved out of modernCV but may have
> > adverse side effects on other tests.
> 
> Thanks for taking a look and for the patch, Günter. I will run the tests
> over night with your patch. Should I also use the patch you propose on
> the beamer thread when I run the tests?
> 
> Scott
> 

Patch applied ...
The test for
        $ ctest -R modernCV
leads to
        3733 - export/examples/modernCV_lyx16 (Failed)
        4956 - export/examples/es/modernCV_lyx16 (Failed)
.

        $ ctest -R beamer
        3426 - export/examples/beamer_lyx16 (Failed)
        3434 - export/examples/beamerlyxexample1_lyx16 (Failed)
        4694 - export/examples/de/beamer_lyx16 (Failed)
        5201 - export/examples/fr/beamer_lyx16 (Failed)
        5590 - export/examples/ja/beamer_lyx16 (Failed)
        6374 - export/templates/beamer-conference-ornate-20min_lyx16 (Failed)
        6408 - export/templates/de_beamer-conference-ornate-20min_lyx16 (Failed)
        6493 - export/templates/es_beamer-conference-ornate-20min_lyx16 (Failed)
        6510 - export/templates/fr_beamer-conference-ornate-20min_lyx16 (Failed)
        6578 - export/templates/ja_beamer-conference-ornate-20min_lyx16 (Failed)

        Kornel

signature.asc
Description: This is a digitally signed message part.