On 28/10/2018 07:36, Daniel wrote:
On 27/10/2018 20:50, Kornel Benko wrote:
Am Samstag, 27. Oktober 2018 19:57:15 CEST schrieb Daniel
<xraco...@gmx.de>:
On 25/10/2018 14:20, Kornel Benko wrote:
Am Donnerstag, 25. Oktober 2018 14:00:35 CEST schrieb Daniel
<xraco...@gmx.de>:
Obviously I should have changed back the first line:
...
else()
set(LYX_USE_STD_REGEX 0)
message(STATUS "Value of MSVC is \"${MSVC15}\"")
message(STATUS "Version = \"${MSVC_VERSION}\"")
if (MSVC_VERSION VERSION_GREATER "10.0")
set(LYX_USE_STD_REGEX 1)
endif()
endif()
...
And here is the output of CMake:
Value of MSVC is ""
Version = "1915"
Still compiles fine (without cleaning build directory).
Best,
Daniel
OK, so the correct commands should be
else()
if (MSVC_VERSION LESS 1915)
set(LYX_USE_STD_REGEX 0)
else()
set(LYX_USE_STD_REGEX 1)
endif()
endif()
Kornel
Can you put this in master?
Daniel
So you are not requiring MSVC_VERSION LESS 1600?
Will do.
Kornel
No, for my personal convenience MSVC_VERSION LESS 1915 is sufficient.
Daniel
Also, could you add it to 2.3.x? That would be great.
Daniel
