Re: Build LyX with MSVC 2017

[Daniel]

On 25/10/2018 14:20, Kornel Benko wrote:
Am Donnerstag, 25. Oktober 2018 14:00:35 CEST schrieb Daniel <xraco...@gmx.de>:
Obviously I should have changed back the first line:
...
else()
         set(LYX_USE_STD_REGEX 0)
         message(STATUS "Value of MSVC is \"${MSVC15}\"")
         message(STATUS "Version = \"${MSVC_VERSION}\"")
         if (MSVC_VERSION VERSION_GREATER "10.0")
                 set(LYX_USE_STD_REGEX 1)
         endif()
endif()
...

And here is the output of CMake:

Value of MSVC is ""
Version = "1915"

Still compiles fine (without cleaning build directory).

Best,
Daniel


OK, so the correct commands should be
else()
        if (MSVC_VERSION LESS 1915)
                set(LYX_USE_STD_REGEX 0)
        else()
                set(LYX_USE_STD_REGEX 1)
        endif()
endif()

        Kornel


So what was the MSVC10 supposed to capture before? Shouldn't it be 
somethink like

else()
        if (MSVC_VERSION LESS 1600)
                set(LYX_USE_STD_REGEX 0)
        else()
                set(LYX_USE_STD_REGEX 1)
        endif()
endif()

Daniel