Re: [LyX/master] Towards a sane character dialog

[Richard Kimberly Heck]

On 05/04/2018 01:39 PM, Juergen Spitzmueller wrote:
> commit fb393b450d661e8b374a7db0177bad9170043dae
> Author: Juergen Spitzmueller <sp...@lyx.org>
> Date:   Fri May 4 19:34:09 2018 +0200
>
>     Towards a sane character dialog

Now that "toggle all" does not come from the dialog, should we get rid
of that entirely?
It never made a lot of sense to me. It mostly seems to affect
LFUN_TEXTSTYLE_APPLY
at this point.

Also, parts of this code from GuiView.cpp:

        case LFUN_DIALOG_SHOW: {
            string const name = cmd.getArg(0);
            string sdata =
trim(to_utf8(cmd.argument()).substr(name.size()));

            if (name == "character") {
                sdata = freefont2string();
                if (!sdata.empty())
                    showDialog("character", sdata);
            }

now seem unnecessary. What this used to do was pass information about
the last used font
to the dialog. But we now don't use that, do we?

Riki