On Fri, Oct 27, 2017 at 03:23:52PM +0000, Richard Heck wrote: > On 10/27/2017 02:25 AM, Scott Kostyshak wrote: > > On Wed, Oct 25, 2017 at 05:31:35PM +0000, Scott Kostyshak wrote: > >> On Sat, Oct 14, 2017 at 02:40:32AM +0000, Scott Kostyshak wrote: > >>> On Fri, Oct 13, 2017 at 06:34:46PM +0000, Richard Heck wrote: > >>> > >>>> It can certainly go to master. I don't see why we shouldn't do it for > >>>> 2.3.x myself, so I'd give it the necessary +1, but I guess I feel like > >>>> Scott should probably chime in on this. > >>> Thanks, yes, for feature patches I like to be involved. > >>> > >>> This feature is fine with me, so since Richard +1'd it, go ahead for > >>> 2.3.0. Thanks for the patch, Helge. > >> Helge or Richard, please commit as soon as possible if you would like > >> this in 2.3.0rc1. > > I committed to master at c4b4305f and to 2.3.x at c480b5bd. I'm still > > curious about thoughts on centralizing the list of text editors. > > It'd be easy just to do it with a variable that held the list, as in the > attached. What might be better would be to run the check on text editors > only once, and then be able to use the results whenever. But that would > be more work.
I agree. I had brought that up also and came to the same conclusion (nice but more work). I suggest you commit your current patch to master. If you think it makes sense to put it in 2.3.x after rc1 so that backporting other potential configure.py changes in the future is easier, then that's fine with me. Thanks for taking a look, Scott
signature.asc
Description: PGP signature
