On Fri, Oct 13, 2017 at 06:34:46PM +0000, Richard Heck wrote: > It can certainly go to master. I don't see why we shouldn't do it for > 2.3.x myself, so I'd give it the necessary +1, but I guess I feel like > Scott should probably chime in on this.
Thanks, yes, for feature patches I like to be involved.
This feature is fine with me, so since Richard +1'd it, go ahead for
2.3.0. Thanks for the patch, Helge. I have two comments:
1. Note that there are three different case styles: "Lilypond files",
"lilypond editor", "LilyPond music". Perhaps that's intentional (e.g.
"LyX software" vs. the "lyx binary") but I wanted to point it out.
2. Can we avoid the duplication of the list of text editors? I'm
guessing there is no simple way to avoid re-searching for duplicate
binaries {i.e. just using the result of checkViewerEditor('a text
editor'} but can we at least create a variable called "text_editors", or
something like that, which we can reuse? It seems that our search for a
BiBTeX editor also copies the list of text editors.
(not related to patch, just a random thought) Regarding (2) above, a
more ambitious (not for 2.3.x) approach might be to use a text editor as
the backup editor for any format that has a MIME "text/whatever". It
doesn't seem that currently would make a difference for many cases
though, so probably not worth the effort.
By the way, the Frescobaldi looks really cool and is under active
development so that's good to see.
Scott
signature.asc
Description: PGP signature
