On 09/12/2017 10:01 AM, Jürgen Spitzmüller wrote: > 2017-09-12 15:51 GMT+02:00 Stephan Witt <st.w...@gmx.net > <mailto:st.w...@gmx.net>>: > > In theory it should make a difference on Linux too. Did you test > with multiple windows open? > > > Yes. I didn't see a difference (which does not mean that there is not > a difference, of course) > > > > > 3. What is with the call of setModal(Qt::WindowModal) in > GuiCompareHistory.cpp? > > Is this really correct? > > > > Dunno. It has been there from day 1 of this class. > > > > But this all does not strike me an argument for not backporting, > since the change in GuiBibtex clearly fixed a problem on the Mac. > > You’re right. It’s not a prerequisite but I’d like to understand > the issue before backporting. > > > We can play safe and guard it in #ifdef Q_OS_MAC, in order to prevent > unwanted effects at least on other OSes. > > In any case, for stable, it's Richard's call. I just thought that some > Mac users struggled heavily with the issue (up to the point that they > though LyX froze and couldn't use the BibTeX dialog anymore).
Maybe it is worth the #ifdef as you say, at least in 2.2.4, so go ahead. No opinion on 2.3.x. Richard
