2017-09-12 15:21 GMT+02:00 Stephan Witt <st.w...@gmx.net>: > Wait a minute, please. I have some questions… > > 1. Why is QDialog::setModal(true) used instead of setModal(true)? >
This code is over 10 years old: http://www.lyx.org/trac/changeset/c9ea6e6eef090b8/lyxgit Maybe the namespace specifier is/was needed with some compiler? I don't know. 2. What is with the other setModal uses? > Shouldn’t these followed by a call to setWindowModality(Qt::WindowModal) > too? > If this is needed on the Mac. It does not seem to make a difference at all on Linux. > > 3. What is with the call of setModal(Qt::WindowModal) in > GuiCompareHistory.cpp? > Is this really correct? > Dunno. It has been there from day 1 of this class. But this all does not strike me an argument for not backporting, since the change in GuiBibtex clearly fixed a problem on the Mac. Jürgen > > Stephan
