On 01/06/2017 12:52 PM, Pavel Sanda wrote:
Paul A. Rubin wrote:
I've opened a ticket (10534) and attached the diff file for an attempt by
me to add them to the script.
Would the patch work if you put all the 'x..' entries at the end of the list?
I don't see reason why we should suddenly change the order for other people.

If you post directly to list I can apply it for you. Also diff -u is nicer
to read.

Pavel
Pavel,

I reran diff with the -u flag and am attaching the result.

Regarding the positioning of the X-Apps entries in the lists, that may need some discussion. I'm not sure end of the list always works. I assume the first one found in each list becomes the default. Putting xviewer (image viewer) after gimp strikes me as undesirable: does a typical user really want to open up gimp just to look at an image? With text editors it's a bit harder to say, but putting xed at the end of the list would, on my system, result in notepad (running under wine) becoming the default text editor. I'd much rather use the Linux application.

On Mint, at least, xed directly replaced gedit and xreader directly replaced evince, so my logic was to put xed immediately after gedit and xreader immediately after evince on theory that, however gedit and evince had "earned" their positions, their substitutes would reasonably fit in the same spots. With xviewer, I frankly couldn't remember which image viewer it replaced. Moving it after, rather than before, kview is likely to make no difference (I suspect not many systems would have both), but I'm fine with doing that. I'm just not crazy about moving it after gimp.

Paul

--- /usr/share/lyx/configure.py.bak     2016-10-23 05:39:10.000000000 -0400
+++ ./configure.py      2017-01-06 12:14:11.357109609 -0500
@@ -595,13 +595,13 @@
 \Format tiff       tif     TIFF                   "" "%s"      "%s"    ""      
"image/tiff"
 \Format xbm        xbm     XBM                    "" "%s"      "%s"    ""      
"image/x-xbitmap"
 \Format xpm        xpm     XPM                    "" "%s"      "%s"    ""      
"image/x-xpixmap"'''
-    path, iv = checkViewerNoRC('a raster image viewer', ['xv', 'kview', 
'gimp-remote', 'gimp'], rc_entry = [imageformats])
+    path, iv = checkViewerNoRC('a raster image viewer', ['xv', 'xviewer', 
'kview', 'gimp-remote', 'gimp'], rc_entry = [imageformats])
     path, ie = checkEditorNoRC('a raster image editor', ['gimp-remote', 
'gimp'], rc_entry = [imageformats])
     addToRC(imageformats % \
         (iv, ie, iv, ie, iv, ie, iv, ie, iv, ie, iv, ie, iv, ie, iv, ie, iv, 
ie, iv, ie) )
     #
     checkViewerEditor('a text editor', ['xemacs', 'gvim', 'kedit', 'kwrite', 
'kate', \
-        'nedit', 'gedit', 'notepad', 'geany', 'leafpad', 'mousepad'],
+        'nedit', 'gedit', 'xed', 'notepad', 'geany', 'leafpad', 'mousepad'],
         rc_entry = [r'''\Format asciichess asc    "Plain text (chess output)"  
"" ""   "%%"    ""      ""
 \Format asciiimage asc    "Plain text (image)"         "" ""   "%%"    ""      
""
 \Format asciixfig  asc    "Plain text (Xfig output)"   "" ""   "%%"    ""      
""
@@ -644,19 +644,19 @@
         'kbibtex', 'sixpack', 'bibedit', 'tkbibtex' \
         'xemacs', 'gvim', 'kedit', 'kwrite', 'kate', \
         'jedit', 'TeXnicCenter', 'WinEdt', 'WinShell', 'PSPad', \
-        'nedit', 'gedit', 'notepad', 'geany', 'leafpad', 'mousepad'],
+        'nedit', 'gedit', 'xed', 'notepad', 'geany', 'leafpad', 'mousepad'],
         rc_entry = [r'''\Format bibtex bib    "BibTeX"         "" ""   "%%"    
""      "text/x-bibtex"''' ])
     #
     #checkProg('a Postscript interpreter', ['gs'],
     #  rc_entry = [ r'\ps_command "%%"' ])
-    checkViewer('a Postscript previewer', ['kghostview', 'okular', 'qpdfview 
--unique', 'evince', 'gv', 'ghostview -swap', 'gsview64', 'gsview32'],
+    checkViewer('a Postscript previewer', ['kghostview', 'okular', 'qpdfview 
--unique', 'evince', 'xreader', 'gv', 'ghostview -swap', 'gsview64', 
'gsview32'],
         rc_entry = [r'''\Format eps        eps     EPS                    "" 
"%%"      ""      "vector"        "image/x-eps"
 \Format eps2       eps    "EPS (uncropped)"       "" "%%"      ""      
"vector"        ""
 \Format eps3       eps    "EPS (cropped)"         "" "%%"      ""      
"document"      ""
 \Format ps         ps      Postscript             t  "%%"      ""      
"document,vector,menu=export"   "application/postscript"'''])
     # for xdg-open issues look here: 
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg151818.html
     # the MIME type is set for pdf6, because that one needs to be 
autodetectable by libmime
-    checkViewer('a PDF previewer', ['pdfview', 'kpdf', 'okular', 'qpdfview 
--unique', 'evince', 'kghostview', 'xpdf', 'SumatraPDF', 'acrobat', 'acroread', 
'mupdf', \
+    checkViewer('a PDF previewer', ['pdfview', 'kpdf', 'okular', 'qpdfview 
--unique', 'evince', 'xreader', 'kghostview', 'xpdf', 'SumatraPDF', 'acrobat', 
'acroread', 'mupdf', \
                    'gv', 'ghostview', 'AcroRd32', 'gsview64', 'gsview32'],
         rc_entry = [r'''\Format pdf        pdf    "PDF (ps2pdf)"          P  
"%%"      ""      "document,vector,menu=export"   ""
 \Format pdf2       pdf    "PDF (pdflatex)"        F  "%%"      ""      
"document,vector,menu=export"   ""
@@ -667,7 +667,7 @@
 \Format pdf7       pdf    "PDF (cropped)"         "" "%%"      ""      
"document,vector"       ""
 \Format pdf8       pdf    "PDF (lower resolution)"         "" "%%"     ""      
"document,vector"       ""'''])
     #
-    checkViewer('a DVI previewer', ['xdvi', 'kdvi', 'okular', 'yap', 'dviout 
-Set=!m'],
+    checkViewer('a DVI previewer', ['xdvi', 'xreader', 'kdvi', 'okular', 
'yap', 'dviout -Set=!m'],
         rc_entry = [r'''\Format dvi        dvi     DVI                    D  
"%%"      ""      "document,vector,menu=export"   "application/x-dvi"
 \Format dvi3       dvi     "DVI (LuaTeX)"          V  "%%"     ""      
"document,vector,menu=export"   ""'''])
     if dtl_tools:

Reply via email to