Le 05/06/2016 12:54, Georg Baum a écrit :
Therefore I would vote to support MSVC 2013 and later, but nothing
earlier.
In light of the lack of support of unicode string literals in MSVC 2013,
the availability of mingw and the fact that a last-minute switch to MSVC
2015 was already necessary for the release of lyx 2.2, I vote for
supporting MSVC >= 2015.
1-3. Introduce lyx::unique_ptr and lyx::make_unique and remove
auto_ptr. This is used by two other patches waiting to be
committed. After the first commit, the option --disable-cxx11 will
fail.
Looks good, I have only one minor comment: Please do not use _MSC_VER
in the sources. This code is better located in config.h
Done. I also removed the compatibility code for MSVC 2012.
Concerning the order of committing, I would first change the
--disable-cxx11 switch to --disable-cxx14, so that we do not loose
the infrastructure, and remove all code that is inside #ifndef
LYX_USE_CXX11. Afterwards, we can gradually introduce more C++11
features like unique_ptr. I can do the configure stuff if you like
btw.
Yes, please do this.
I won't comment on the other items. IMHO, discussing all these in
one message makes things more complicated. I would prefer to go step
by step.
Thanks. Take your time.
