On Mon, Apr 25, 2016 at 01:04:55PM -0400, Scott Kostyshak wrote: > On Mon, Apr 25, 2016 at 07:31:46AM +0200, Stephan Witt wrote: > > Am 25.04.2016 um 03:58 schrieb Scott Kostyshak <skost...@lyx.org>: > > > > > > On Sun, Apr 24, 2016 at 09:52:48PM +0200, Stephan Witt wrote: > > >> Am 24.04.2016 um 07:11 schrieb Scott Kostyshak <skost...@lyx.org>: > > >>> > > >>> On Sun, Apr 24, 2016 at 12:03:15AM -0400, Scott Kostyshak wrote: > > >>>> On Fri, Apr 22, 2016 at 06:08:31PM +0100, Guillaume Munch wrote: > > >>>>> Le 18/04/2016 02:20, Scott Kostyshak a écrit : > > >>>>>> > > >>>>>> I imagine Guillaume did not intend this as a full patch, > > >>>>> > > >>>>> Indeed. > > >>>>> ... > > >>>>> The difference between the bad display and the good display in this > > >>>>> example > > >>>>> svg is the formula in the bottom right, which I can see on your > > >>>>> screenshot. > > >>>>> To you see this formula before the patch? > > >>>> > > >>>> Ah yes I do see what you mean. I did not realize that. Because it was > > >>>> so > > >>>> small I just assumed it was corrupted. > > >>>> > > >>>>> It is strange that it displays so small, here it is at least twice as > > >>>>> wide. > > >>>>> But here too I find it too small. I tested and the preview is smaller > > >>>>> than > > >>>>> in 2.1.4, so there may be a regression. > > >>>> > > >>>> Interesting. This could be a separate issue. I will do a bisect. > > >>> > > >>> Bisect led me here: c053a939 > > >>> > > >>> Stephan can you reproduce on OS X? > > >> > > >> Yes. A little bit tricky because these commits doesn’t compile on my > > >> system. > > >> > > >>> To reproduce, download lyxinkscape.lyx and lyxinkscape.svg from #9778. > > >>> Do you see a difference in the size displayed in LyX before/after > > >>> c053a939. > > >>> > > >>> I wouldn't be surprised if this depends on the Qt version (e.g. > > >>> different Qt "features" and difficulty of Qt getting the high res right) > > >> > > >> No, the problem is the assignment of params_.pixel_ratio to 4.0. > > >> It seems not needed anymore. I’ve made it to overcome the size problems > > >> with the internal SVG-converter on HiDPI displays. > > >> > > >> The attached patch fixes it on my system. > > > > > > Fixes it for me as well, and the patch seems simple. Do you recommend it > > > for 2.2.0? > > > > Yes, I do. Thanks for bisecting. > > Please push.
Note (for archival purposes) that Stephan committed this to master at 21e4e939. Scott
signature.asc
Description: PGP signature
