Le 25/01/2016 21:17, Guillaume Munch a écrit :
I had done this at first but then I thought that the difference in
properties at-point/not-at-point could result in differences. By reading
it again, with hindsight, of course this makes no difference, so I will
be happy to get rid of the trick entirely, my initial intention. However
I am going to replace it with a direct call to getFeatureStatus, unless
you think this is a bad idea. Thanks for spotting this circumvolution.

The question of bypassing the dispatch/getStatus mechanism is orthogonal to what you are doing. We will need to discuss the merits of the approach one day, but it may be important to proper scripting one day. To be frank, I do not have clear views on the matter.

[...]

- Are there places where one sets several features at once? Or is it
just that we this multi-arguments feature because the lfun is declared
like that?

Yes, that's what the tabular dialog does.

I see, thanks.

- The code of InsetMathCases::doDispatch is indeed strange. I suspect
that the break after cur.undispatched() should be a return; the
recordUndo seems bogus too.

I suggest just adding a FIXME for the moment instead of attempting a
last minute fix of what's not broken (unless you see what bug this may
cause).

Please do just that, we'll come to it later.

The next time I can work on this is tomorrow evening. If you agree with
the above changes I can commit it straight away since the changes seem
trivial, to spare some time.

This is OK to me, you have my +1 in advance.

JMarc

Reply via email to