Scott Kostyshak wrote: > From what I understand, the renaming was done to avoid confusion from > overloading (see the documentation for the signal in Qt 4.8 or Qt 5). I > think this is related to this Qt bug [6]. In essence, this seems just to > be a renaming from error() to errorOccurred(). > > Attached is a patch.
+1, since it does not affect older qt versions, and it is important for qt 5.6. > I have a style question regarding the change in GuiProgress.cpp: should > I include only the visual line in the preprocessor if directive or > should I include the full C++ statement? I chose the visual line since > that makes it more clear where the difference is, but I would not be > surprised if someone prefers the full statement. I prefer it the way you did it, but this is one of the style questions you can fight wars about, and I know people with a strong preference for including the complete C++ statement, so I usually do not insist on doing it this way. Georg
