On Sun, Aug 23, 2015 at 12:26:44PM -0400, Scott Kostyshak wrote: > I am getting many messages such as > > QObject::connect: Connecting from COMPAT signal > (QProcess::error(QProcess::ProcessError)) > > now in the terminal when using LyX with Qt 5.6dev. It does not cause > any problems that I can notice. I am not planning to look into this > further for now. My plan is to wait a couple of months, see if goes > away with an updated 5.6dev. If it does not, I might bisect Qt to see > which commit introduced it; and/or ask on the mailing list. > > I just wanted to let the lyx-devel list know. If anyone else is > testing Qt 5.6dev, do you see this message also?
I still get these messages, now on Qt 5.6beta, so I did some digging. It seems that they mean that a signal we are using has been deprecated ([1] and [2]). Indeed, looking at the documentation for 5.6 [3], there is no QProcesss::error() signal, like there is in Qt 4.8 [4] and earlier Qt 5 versions [5]. From what I understand, the renaming was done to avoid confusion from overloading (see the documentation for the signal in Qt 4.8 or Qt 5). I think this is related to this Qt bug [6]. In essence, this seems just to be a renaming from error() to errorOccurred(). Attached is a patch. I have a style question regarding the change in GuiProgress.cpp: should I include only the visual line in the preprocessor if directive or should I include the full C++ statement? I chose the visual line since that makes it more clear where the difference is, but I would not be surprised if someone prefers the full statement. Scott [1] http://www.qtcentre.org/threads/22098-QObject-connect-Connecting-from-COMPAT-signal [2] http://www.qtforum.org/article/12778/connecting-from-compat-signal-qaction-activated.html [3] https://doc-snapshots.qt.io/qt5-5.6/qprocess.html#signals [4] http://doc.qt.io/qt-4.8/qprocess.html#signals [5] http://doc.qt.io/qt-5/qprocess.html#signals [6] https://codereview.qt-project.org/#/c/114451/
signature.asc
Description: PGP signature
