On Sat, Nov 28, 2015 at 02:05:06AM +0100, Uwe Stöhr wrote: > commit 764cc2be1f6a56d946235f1ed7804601df829a16 > Author: Uwe Stöhr <uwesto...@lyx.org> > Date: Sat Nov 28 02:04:57 2015 +0100 > > installer: remove residues of metafile2eps >
Hi Uwe, Two points: 1. There is an objection to removing metafile2eps. See here: https://www.mail-archive.com/search?l=mid&q=n3a58i%24vs8%241%40ger.gmane.org 2. For commits like this, can you please reference the other commit (by an 8-digit hash) that this one basically amends? Otherwise, how do we know to find this commit if we decide to revert the other commit? I know it might not make sense to always thing "how can I make it so it is easy to revert my commit?" but actually I think that thinking like that creates good programming habits, specifically self-contained changes and referencing of relevant commits. Best, Scott
signature.asc
Description: PGP signature
