John Levon <[EMAIL PROTECTED]> writes:
| + if (!lyxrc.cursor_follows_scrollbar) {
| + waitForX();
| + return;
| }
| +
| + LyXText * vbt = bv_->text;
| +
| + int height = vbt->DefaultHeight();
| + int first = static_cast<int>((bv_->text->first + height));
| + int last = static_cast<int>((bv_->text->first +
| workarea_->height() - height));
Can these int be const? If so make them so.
| double value = workarea_->getScrollbarValue();
|
| - if (value == 0) return 0;
| + // hemm ...
| + if (int(value) == 0) return 0;
Wouldn't it be more natural to do "if (value == 0.0)", than using a
cast?
workarea_->getScrollbarValue();
| pair<float, float> p = workarea_->getScrollbarBounds();
| double max = p.second;
|
| + // hemm ...
| if (value == max) return 0;
What's "hemm" about this?
| Index: src/frontends/Timeout.C
| ===================================================================
| RCS file: Timeout.C
| diff -N Timeout.C
| --- /dev/null Tue May 5 22:32:27 1998
| +++ src/frontends/Timeout.C Wed Feb 7 13:45:33 2001
| @@ -0,0 +1,73 @@
| +/*
| + * Timeout.C
| + * (C) 2001 LyX Team
| + * John Levon, [EMAIL PROTECTED]
ha!
| +Timeout::Pimpl::~Pimpl()
| +{
| +}
Do you really need this?
Remove if possible.
| diff -N Timeout_pimpl.C
| --- /dev/null Tue May 5 22:32:27 1998
| +++ src/frontends/xforms/Timeout_pimpl.C Wed Feb 7 13:45:33 2001
| @@ -0,0 +1,60 @@
| +/*
| + * Timeout_pimpl.C
| + * (C) 2001 LyX Team
| + * John Levon, [EMAIL PROTECTED]
hmm da hm...
Lgb
