On 2015-10-19, Uwe Stöhr wrote: > Am 19.10.2015 um 20:55 schrieb Scott Kostyshak:
>> There is some at lib/doc/Development.lyx >>> I see lots of diffs of the form >>> #LyX file created by tex2lyx 2.2 >>> -\lyxformat 497 >>> +\lyxformat 498 >>> and the commit ce933b1e14 has incremented the format to 498. Could that >>> alone make the tests fail? > I don't understand what I made wrong. I only changed something in a > module and added a fileformat change for lyx2lyx. I did not change any > tex2lxy test file nor did I change tex2lyx code. A fileformat change is IMO a "big" change that should be agreed with the release manage so short before an alpha release. As the tex2lyx tests compare the result of converting a *.tex file with a stored example of the expected LyX file, they need updating with every change to the default settings and bits in these LyX files, including the fileformat number. > I also followed lib/doc/Development.lyx sec. 2.3. This references sec. > 3.2.2 and I tried that too, but this is not possible on my PC: If the hint that a fileformat change requires adapting the test examples is missing there, this is a documentation bug. > So if anybody could please tell me what I should do I will do this and > also update lib/doc/Development.lyx accordingly. If there is agreement to the fileformat change, replacing the fileformat number in the *.lyx and *.lyx.lyx files in the tex2lyx tests would (hopefully) solve the issue. I can confirm that before these changes but applying my patches for "combining lines below", tests passed. In addition, adding the "change the fileformat numer for tests" requirement to Development.lyx would help prevent others to fall in this trap and frustration by others frentically trying to get the tests in shape before a release. Günter
