Guenter Milde wrote: > I see. > Interestingly, despite the "tests passed" message, git reports changed > files: > > diff --git a/src/tex2lyx/test/test-insets-basic.lyx.lyx > b/src/tex2lyx/test/test-insets-basic.lyx.lyx index 34c2ddc..3679ac5 100644 > --- a/src/tex2lyx/test/test-insets-basic.lyx.lyx > +++ b/src/tex2lyx/test/test-insets-basic.lyx.lyx > @@ -6042,7 +6042,7 @@ h > > \end_inset > > - e̹ e̜ e̟ e̠ e̠ ë e̽ e̩ e̩ e̯ e˞e > + e̹ e̜ e̟ e̱ e̱ ë e̽ e̩ e̩ e̯ e˞e > \begin_inset script superscript > > \begin_layout Plain Layout > diff --git a/src/tex2lyx/test/test-insets.lyx.lyx > b/src/tex2lyx/test/test-insets.lyx.lyx index 92da376..2da897c 100644 > --- a/src/tex2lyx/test/test-insets.lyx.lyx > +++ b/src/tex2lyx/test/test-insets.lyx.lyx > @@ -6481,7 +6481,7 @@ h > > \end_inset > > - e̹ e̜ e̟ e̠ e̠ ë e̽ e̩ e̩ e̯ e˞e > + e̹ e̜ e̟ e̱ e̱ ë e̽ e̩ e̩ e̯ e˞e > \begin_inset script superscript > > \begin_layout Plain Layout > > Unfortunately, I don't know enough about the tests to start investigating.
It is quite easy: "make alltests" does never change the test references. If you would run it in a clean tree with only the unicodesymbols patch applied, then the tests would fail, as they did for Kornel. A git diff afterwards would not show any changes below src/tex2lyx/test. Since you have changed test references in your tree (as shown by git diff), it means that you did either call "make updatetests", or you did run tex2lyx manually. If you did neither of that then it would be a mystery in my eyes. > I am pretty sure the unicodesymbols fix is correct, I am not sure whether > the round-trip result is as it should be. Both are correct. Since the patch in http://www.lyx.org/trac/ticket/9764 does not revert the introduction of \b for 0x0331. and the tests are currently failing, it is expected that they still fail after applying the patch. Since it is clear now that the change 268bd00 which made the tests fail was correct, we should proceed in two steps: 1) run "make updatetests" in a clean tree and submit the result with a log referring to 268bd00. This makes it clear that the changed test cases are solely caused by that change. 2) submit the patch in ticket 9764. This would then proove that the patch does not change anything in tex2lyx. Georg
