On 2015-06-15, Georg Baum wrote: > Uwe Stöhr wrote: >> Am 09.06.2015 um 20:38 schrieb Georg Baum:
... >>> At least the function names (e.g. quotedWinPath) suggest that the quoting >>> is still windows specific. >> Yes, because this function is only called if the OS is Windows, for all >> other OSes no quoting is necessary and the command is output as it is >> already the case. > Well, I tried to explain why the quoting is _not_ a windows-only thing: > Paths with spaces are not only allowed on windows. They are much less common > on unix, but they exist. Therefore, if checkProg() has a problem with spaces > in paths, then the fix must not be windows specific. > With Günters patch this solution is obsolete now, but IMHO it is important > to understand that spaces in paths or filenames are not windows-specific. If > we handle them incorrectly somehwere, then this wil most likely be detected > by windows users, but the fix must not be made for a single OS. Just for the record: This special patch was Windows specific, because on Windows, Inkscape is not installed into the binary path (binaries for end-users not in the PATH are uncommon on Unix (but not impossible)). For this reason, only on Windows the complete program call had spaces (spaces in the command name are uncommon in all operating systems I know). If there are problems with spaces in the "path" argument to Check...() functions, these should be handled OS-independently. Günter
