Uwe Stöhr wrote:

> The attached patch fixes
> http://www.lyx.org/trac/ticket/7657
> for me.
> 
> Could some pythionist please review this?

First you need to explain why you use this complicated quoting, and what 
problem it solves. If such a quoting is really needed, then it needs to be 
wrapped in a helper, manually doing replacements on each call is too error 
prone. Finally, the interface of getInkscapeBinary() needs to be the same 
for windows and unix, having quoted stuff for one OS and not for the other 
will lead to bugs.


Georg

Reply via email to