Re: [LyX/master] Prevent accidental usage of wrong copy constructor

[Richard Heck]

On 11/14/2014 09:02 PM, Jean-Marc Lasgouttes wrote:

I agree with you actually. My points were probably:
* we should get rid of the few users of boost::noncopyable
* ot would be better to use the terse style of comments we use elsewhere.

It turns out there are only three places we use it. Now there are zero.

Richard

Le 14 novembre 2014 18:48:34 CET, Georg Baum <georg.b...@post.rwth-aachen.de> a écrit :

    Jean-Marc Lasgouttes wrote:

        Le 11/11/2014 20:58, Georg Baum a écrit :

            commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author:
            Georg Baum <b...@lyx.org> Date: Tue Nov 11 07:22:14 2014

+0100 Prevent accidental usage of wrong copy constructor

        Is this what we use boost:noncopyable for in some places? It

would be nice to keep the same form in all these places.

    This used to be boost::noncopyable a long time ago, but IIRC this is now
    considered evil, because it pulls in a header just for very little benefit.

    Please correct me if I am wrong, I'll change this if that is the case.



    Georg