Le 28/07/2014 17:35, Scott Kostyshak a écrit :
JMarc (don't worry if you can't look at this before you leave on vacation), I first interpreted your response in this thread as disagreeing with the patches I proposed. Upon rereading I think there was a misunderstanding because of poor description on my part. You actually made the same change I suggested in the first patch in your commit at ad56bded.
I think we agree indeed.
The other patches still apply cleanly. There are three patches from my first email and one patch based on your suggestion referencing the Apple HIG (our recent discussion on UI guides is what brought this thread back in my mind). I reattach all four to this email (but I did not change anything).
I am surprised that you have to lookupthe read-only status for LFUN_FILE_INSERT_PLAINTEXT. The flags in LyXAction.cpp (in the case Noop) are enough to indicate that this particular function does not work in read-only. Instead of fixing it by hand, the global mechanism used elsewhere should apply here too.
JMarc
