On Fri, Feb 21, 2014 at 10:50 AM, Kornel Benko <kor...@lyx.org> wrote: > Am Freitag, 21. Februar 2014 um 10:36:51, schrieb Scott Kostyshak > <skost...@lyx.org> > >> On Thu, Feb 20, 2014 at 4:02 AM, Jean-Marc Lasgouttes > >> <lasgout...@lyx.org> wrote: > >> > 19/02/2014 23:02, Scott Kostyshak: > >> > > >> >> I'm planning to commit these after 2.1 is released. If anyone has > >> >> comments or would like to see them in 2.1 let me know. > >> > > >> > > >> > Concerning menus, the Apple HIG says: > >> > > >> > Ensure that a submenu's title is undimmed even when all its commands are > >> > unavailable. As with menu titles, it's important for users to be able to > >> > view a submenu's contents, even if none of them are available in the > >> > current context. > > > > I prefer this behaviour too. > > > >> > >> > https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/Menus/Menus.html#//apple_ref/doc/uid/TP30000356-TP6 > >> > >> This has a lot of good info. Thank you for the reference. > >> I gave a poor description of the patches. They disable the LFUNs and > >> only affect the menus indirectly. I was motivated by the following: > >> 1. Open help > Introduction (it should be opened as read only). > >> 2. Go to Insert > File > Plain Text and select a file > >> > >> The file is inserted. This should not happen for read only. > >> > >> > I did not look at what other HIGs might say, but in this case it is >> > clear. > >> > And if one wants to disable submenus which contains only disabled >> > entries, > >> > it can be done automatically in the Menus.cpp machinery. > >> > >> As for the submenus not being accessible if all of the items are > >> disabled, attached is a patch. > > > > :(
I think that I again gave a poor description of the patch (I'm on a roll here). The patch *enables* expanding of submenus even when all of the items are disabled. For example, go to Help > Introduction. The submenu Insert > Special Character now expands, where without the patch it does not. Note that this is also consistent with LibreOffice. Scott
