On Wed, Mar 19, 2014 at 8:19 AM, Stephan Witt <st.w...@gmx.net> wrote:
> Am 18.03.2014 um 09:17 schrieb Vincent van Ravesteijn <v...@lyx.org>:
>
>> On Sun, Mar 16, 2014 at 9:58 PM, Stephan Witt <st.w...@gmx.net> wrote:
>>> Am 02.09.2013 um 17:50 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>:
>>>
>>>> 02/09/2013 17:38, Vincent van Ravesteijn:
>>>>> This code apparently only works when version suffix is set to -2.0 and
>>>>> -1.6. In some sense, this is rather arbitrary and the use might have any
>>>>> suffix he wants. On Windows the user dir looks like: "LyX2.0".
>>>>
>>>> Yes, I forgot this part :) This needs to be a bit more general...
>>>>
>>>> A solution would be as I proposed to call some python script when the user 
>>>> directory does not exist. This python script would be provided by the 
>>>> packager (at least for now). Nothing would happen if there is no script.
>>>>
>>>> That would IMO be a good short-term solution, allowing Stephan to hardcode 
>>>> for now according to the usual mac naming conventions...
>>>
>>> I'd like to reanimate this issue. The problem mentioned in this thread is 
>>> not solved.
>>>
>>> For Mac users hardcoded version suffixes are no problem. They are -1.6 
>>> resp. -2.0, period.
>>>
>>> For Linux or Windows users the attached patch has no effect.
>>
>> Is there a problem then ? You say that you can fix it on Mac, and
>> there is no problem on Linux.
>
> The problem was I didn't test it on Linux. Now I've tried it on Ubuntu 12.04
> and cannot see any problem. I built a LyX with version suffix -2.1 just like
> the Mac version and the automatic user configuration migration isn't triggered
> on reconfigure run. Some developers are afraid to be affected by this change
> unintentionally.

There is this check whether the system is 'darwin'. So, it doesn't do
anything on Linux or Windows, right ?

>
> So, it improves the situation for users upgrading from 2.0.x to 2.1.x on Mac.
> I want to commit this change.
>

I still don't like the hardcoded version suffices. Also, this
introduces different behaviour on different platforms without a good
reason. Last, for LyX 2.2, these need to be updated again, but will
anyone remember to do so ?

I propose to apply this to LyX 2.1, but to revert it after it is released and
- to work toward a general solution, or
- to move this logic into the MacOSx packaging directory.

Vincent

Reply via email to