Stephan Witt wrote:

> In principle you're right. But I've never seen LyX on X11 OSX. I'm not
> sure what this is - X11 OSX. Perhaps a Darwin application running with X11
> server like old Gimp versions.

Exactly. I have to admit that it is years ago since I saw an OS X with X 
server (and it was on a PPC ibook).

> I don't believe it is possible to compile and run this with our
> auto tools build. So, I think one can say: we don't support X11 on Mac.
> 
> At least I don't know how to create such a piece of program.

Me neither. I simply looked at the #defines, and from those it looks like 
qt4 can be built for this configuration.

> This is a possibility. The problem with this approach is: Q_WS_MACX is a
> check for a window system and Q_OS_MACX a check for a platform (I think
> you're aware of this difference).

Yes, I am.

> With Qt-4.x and LyX the check for the
> platform is a synonym for the check for the window system.

You mean with Qt 5.x?

> And I'm not sure if Q_xxx macros are sacrosanct and shouldn't defined by
> LyX.

In that case one could easily use LYX_WS_OSX in the code and do the 
following in config.h:

#if QT_VERSION >= 0x050000
#ifdef Q_OS_MACX
#define LYX_WS_MACX
#endif
#else
#ifdef Q_WS_MACX
#define LYX_WS_MACX
#endif
#endif

> But the argument with Qt-4.x testing is strong.
> 
> Should I try this?

I think that would be great. Since Benjamin helped so nicely with bug fixing 
I think he deserves a version which build easily with qt5.


Georg


Reply via email to