>> >> It seems that it would be better to have LyX macros handling the following >> cases: >> - QT + OS X => LYX_QT_OSX >> - QT5 + OS X => LYX_QT5_OSX >> - QT4 + OS X => LYX_QT4_OSX >> - QT4 + OS X + COCOA => LYX_QT_OSX_COCOA >> - QT4 + OS X + X11 => LYX_QT_OSX_X11 >> >> this would make the code more readable and easier to maintain IMHO. > > I'm not sure if this is really helpful. > > Most of the time if it's not avoidable to guard code by ifdefs one > has a dedicated reason to make separate code fragments. Either its > some os issue or its some window system difference or a version issue > of any kind. I wouldn't make a define for any possible combination. > > Stephan Not for any combination, but for those useful as for ifdefs in the code. For example, having
#idef LYX_QT_OSX_COCOA instead of #if defined(QT_MAC_USE_COCOA) or (QT_VERSION > 0x050000) since Qt5 has no QT_MAC_USE_COCOA macro defined but is based on cocoa anyways. Benjamin
signature.asc
Description: Message signed with OpenPGP using GPGMail
