Am 20.08.2013 um 16:38 schrieb Stephan Witt <st.w...@gmx.net>:

> Am 19.08.2013 um 10:44 schrieb Jürgen Spitzmüller <sp...@lyx.org>:
> 
>> Stephan Witt wrote:
>>> So, we have to revert the addition of subdir-objects to the AM_INIT_AUTOMAKE
>> 
>> I'll do this in a minute.
>> 
>>> option list. But there will be a problem in the future. One idea I have to
>>> solve this: Split the Encoding class into a base class for tex2lyx and LyX
>>> and a sub-class for LyX only. Then link the base class with tex2lyx and the
>>> sub-class with LyX.
>>> What do you think?
>> 
>> Sounds sensible, but note that some other classes (Lexer, ModuleList) are 
>> probably affected as well (they use TEX2LYX conditions as well).
> 
> For the Encoding class I've made a patch for review.
> 
> It's mostly a split at the encoding stuff and the static helper methods.
> The helper methods I've moved to the new class BufferEncodings.
> 
> The price I had to pay is to move the CharInfoMap to Encoding.h for the
> unicodeencodings getter method I need in BufferEncodings implementation.
> 
> Is there a better approach to get the thing done?
> Possibly implement all getters for textcommand, textpreamble, etc. of the
> unicode encoding for a char_type c?

Like this.

I noticed I didn't include the class BufferEncodings in previous patch :(
I have to get it from backup later… and cannot attach it now.

Stephan

Attachment: 0002-Encoding.diff
Description: Binary data

Reply via email to