Re: error building xvkbd: undefined reference, add to linker command line?

[Kornel Benko]

It turned out, the problem is the link-stage. The (needed) library libXMU
is added automatically by the gnu-cc in case of ubuntu 12.04, but not
in case of ubuntu 13.04.

The attached patch for development/autotests/CMakeLists.txt worked on both 
platforms.

Ok to commit to 2.1-staging?

        Kornel

Am Dienstag, 9. Juli 2013 um 14:56:53, schrieb Scott Kostyshak 
<skost...@lyx.org>
> I did a clean compile and the second patch with the inversion works
> well. Thanks! Scott
> 
> On Tue, Jul 9, 2013 at 2:36 PM, Kornel Benko <kor...@lyx.org> wrote:
> > Am Dienstag, 9. Juli 2013 um 14:23:04, schrieb Scott Kostyshak
> > <skost...@lyx.org>
> >
> >> The first patch worked well. Should I test the second patch also?
> >
> >
> >
> > You could invert the test for pkg-config to test the second patch.
> >
> > CMakeLists.txt:31 ->
> >
> > if(NOT PKG_CONFIG_FOUND)
> >
> >
> >
> > Kornel
diff --git a/development/autotests/CMakeLists.txt b/development/autotests/CMakeLists.txt
index 9933a4a..10abf4c 100644
--- a/development/autotests/CMakeLists.txt
+++ b/development/autotests/CMakeLists.txt
@@ -29,33 +29,32 @@ if(Q_WS_X11)
   endif()
   find_package(PkgConfig)
   if(PKG_CONFIG_FOUND)
-    pkg_check_modules(XAWLIB xaw7)
-    if (XAWLIB_LIBRARIES)
-      list(APPEND XVFBDLIBS ${XAWLIB_LIBRARIES})
-    else()
-      list(APPEND Missing Xaw7)
-    endif()
-    pkg_check_modules(XTEST xtst)
-    if (XTEST_LIBRARIES)
-      list(APPEND XVFBDLIBS ${XTEST_LIBRARIES})
-    else()
-      list(APPEND Missing xtst)
-    endif()
+    foreach(_lb "xaw7" "xmu" "xtst")
+      pkg_check_modules(${_lb}LIB ${_lb})
+      if(${_lb}LIB_LIBRARIES)
+        list(APPEND XVFBDLIBS ${${_lb}LIB_LIBRARIES})
+      else()
+        list(APPEND Missing ${_lb})
+      endif()
+    endforeach()
   else()
-    find_library(XAW7LIB "Xaw7")
-    if(XAW7LIB)
-      list(APPEND XVFBDLIBS ${XAW7LIB})
-    else()
-      list(APPEND Missing Xaw7)
-    endif()
+    foreach(_lb "Xaw7" "Xmu")
+      find_library(${_lb}LIB ${_lb})
+      if(${_lb}LIB)
+        list(APPEND XVFBDLIBS ${${_lb}LIB})
+      else()
+        list(APPEND Missing ${_lb})
+      endif()
+    endforeach()
     foreach(_lb Xt XTest X11)
       if(X11_${_lb}_LIB)
-	list(APPEND XVFBDLIBS ${X11_${_lb}_LIB})
+        list(APPEND XVFBDLIBS ${X11_${_lb}_LIB})
       else()
-	list(APPEND Missing ${_lb})
+        list(APPEND Missing ${_lb})
       endif()
     endforeach()
   endif()
+  list(REMOVE_DUPLICATES XVFBDLIBS)
 
   if(Missing)
     message(STATUS "Missing Libraries or programms to create xvkbd: ${Missing}")

signature.asc
Description: This is a digitally signed message part.