In article <51506a27.3060...@lyx.org>, Jean-Marc Lasgouttes <lasgout...@lyx.org> wrote:
> Le 22/03/2013 12:59, pdv a écrit : > > Hi everyone, > > > > I've developed a patch which solves the scrolling issue on "OS X". > > I assume that there have been different scrolling issues but the one I'm > > referring to is the one diagnosed by Stephan Witt > > Hi, > > This looks awesome... My current plan was to work on this at developers' > meeting, actually. It would be great to be able to include something > like this in LyX 2.1.0, but the code cannot be used as it is. To be > frank I have not made the effort of understanding how it actually works. > > In case you are interested in working more on this coe, here are a few > remarks: > > * be careful about indentation: use tab characters, and in general use > the same coding style as the rest of the > > * the tests for arabic/hebrew are not needed. What you want is a test > for Language::rightToLeft(), I think. > > * there seem to be a lot of common code between CursorX() and > getColumnNearX(). It should be factored. > > * in general the code used should be the same as the one that selects > strings to paint in the row painter. Less code, less bugs. > > I have not yet tried this code out, but it compiles fine with latest trunk. > > JMarc Thanks for the comments. I use XCode which does the indendation so I was not aware of tab-issues. I know that CursorX() and getColumnNearX() look similar but I'm not sure this can be simplified any further. But see also your next message. I'll take another look. Regards, P. De Visschere
