Am 25.03.2013 um 16:15 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>:
> Le 22/03/2013 12:59, pdv a écrit : >> Hi everyone, >> >> I've developed a patch which solves the scrolling issue on "OS X". >> I assume that there have been different scrolling issues but the one I'm >> referring to is the one diagnosed by Stephan Witt > > Hi, > > This looks awesome... My current plan was to work on this at developers' > meeting, actually. It would be great to be able to include something like > this in LyX 2.1.0, but the code cannot be used as it is. To be frank I have > not made the effort of understanding how it actually works. > > In case you are interested in working more on this coe, here are a few > remarks: > > * be careful about indentation: use tab characters, and in general use the > same coding style as the rest of the > > * the tests for arabic/hebrew are not needed. What you want is a test for > Language::rightToLeft(), I think. > > * there seem to be a lot of common code between CursorX() and > getColumnNearX(). It should be factored. > > * in general the code used should be the same as the one that selects strings > to paint in the row painter. Less code, less bugs. > > I have not yet tried this code out, but it compiles fine with latest trunk. Ok, I've tried it and it looks good. I didn't find the time to dig into the details, too. Sorry. I agree with JMarc - it needs some work. What's your plan, do you want to work on that or should we continue your work? Thank you for your afford! Regards, Stephan
