On 02/11/2011 07:58 AM, Jürgen Spitzmüller wrote:
Jürgen Spitzmüller wrote:
Jesper, does your plan to implement export menu disabling still stand?
Sorry, I could not resist.
The attached patch implements this feature. I've implemented in a way that is
extensible (in case we want other UI configuration flags later).
The actual selection of formats that appear in the export menu by default is
not in any way fixed, I've added what I think are the basic ones, but this
list can be changed after the thing is in. I have not spent much time on this
specific issue.
OK?
The parts of this that touch the Graph class make me uncomfortable. The
Graph class should be just that: a representation of a Graph, with
methods for searching it, etc. I would much prefer that we leave
Graph::getReachable() alone, and do whatever filtering we need to do
where we need to do it (in this case, in Converters::getReachable(), I
would suppose).
I can see that you're just adding another bool like only_viewable, but
I've been meaning to take it out in the next round of cleanup.
Richard
