Another version of the patch is attached, this time hopefully readable by everyone... 
There was one additional line in GuiApplication.cpp that I took out - it was commented out anyway and corresponded to the initial test I described in http://wiki.lyx.org/Mac/LyXmodifierKeys#sMac.LyXmodifierKeys_5 (which is no longer the way I do things). It was put in by Stephan in rev. 34812. 
 

Attachment: modifierKey-3.patch
Description: Binary data


Below are some more responses:

On Sep 18, 2010, at 12:48 PM, Pavel Sanda wrote:
i would be happy if we can get rid of any additional #ifdefs. it needs to be tested
but i guess except this part:

+ dontswapCB->setVisible(false);

all other parts of code could be normally written and no GUI_DONTSWAPCB_VISIBLE needed.


I took those two #ifdef out.


+         <string>Do not swap Meta and Control keys</string>

add something like "on MacOSX"...


Since this text only shows up on Mac anyway, I just modified the text slightly and added your suggestion in a tooltip instead.

void LyXRC::setDefaults()
{
+ mac_dontswap_ctrl_meta = false;

concerning the default value - this is the current value lyx uses or are we changing defaults?
also put this assignment more down between other rc settings concerning keyboard.


Yes, the default _is_ to swap Apple and Ctrl keys. That's what makes this so annoying to emacs users. And by _not_ swapping these modifier keys we are changing the default. The check box unchecked when the default setting is desired. Basically I'm following the nomenclature as dictated by Qt's convoluted Mac behavior (their Attribute  "MacDontSwapCtrlAndMeta" is false by default)...   

other parts looks fine. (dow we have already GPL statement from you?)

Probably not - I'll send it in the next message.

Jens

Reply via email to