> OK, here is the new patch for the current LyX 2.0 in svn trunk:
please note that its difficult to directly comment on your pacthes, because the
attachment is signed as octet-stream type. one need for examples
application/text
(maybe only naming the attachment .patch would help, depends on your mailer...)
some comments:
> this, SIGNAL(changed()));
> connect(scrollzoomValueCO, SIGNAL(activated(int)),
> this, SIGNAL(changed()));
> +
> +// GUI_DONTSWAPCB_VISIBLE reveals checkbox for switching Ctrl and Meta on
> Mac:
> +#ifdef Q_WS_MACX
> +#if QT_VERSION > 0x040600
> + connect(dontswapCB, SIGNAL(toggled(bool)),
> + this, SIGNAL(changed()));
i would be happy if we can get rid of any additional #ifdefs. it needs to be
tested
but i guess except this part:
> + dontswapCB->setVisible(false);
all other parts of code could be normally written and no GUI_DONTSWAPCB_VISIBLE
needed.
> + <string>Do not swap Meta and Control keys</string>
add something like "on MacOSX"...
> void LyXRC::setDefaults()
> {
> + mac_dontswap_ctrl_meta = false;
concerning the default value - this is the current value lyx uses or are we
changing defaults?
also put this assignment more down between other rc settings concerning
keyboard.
other parts looks fine. (dow we have already GPL statement from you?)
pavel
