Re: [Code Review] LyX-Outline - Two Column TocModel

[Peter Kümmel]

Attached some other 'low hanging fruits'.

An I get this warning when starting:
    Object::connect: No such slot
    lyx::frontend::CorkboardWidget::setCorkboardRoot(const QModelIndex &)
    in ..\..\..\..\lyx-outline\src\frontends\qt4\CorkboardWidget.cpp:78

Peter

=== modified file 'src/frontends/qt4/Corkboard.cpp'
--- src/frontends/qt4/Corkboard.cpp     2010-05-18 17:15:39 +0000
+++ src/frontends/qt4/Corkboard.cpp     2010-05-25 16:35:36 +0000
@@ -85,8 +85,8 @@
     QLineEdit* corkEditor = qobject_cast<QLineEdit*>(editor);
     QString newString = corkEditor->text();
     dataManager->updateDocument(newString);
-    dataManager->corkboardChange == false;
-    dataManager->modelCommit == false;
+    dataManager->corkboardChange = false;
+    dataManager->modelCommit = false;
 }
 
 QModelIndex Corkboard::indexAt(const QPoint& point) const {
@@ -347,7 +347,7 @@
 void Corkboard::paintEvent(QPaintEvent* event) {
        // Paints the contents of OutlineData within the view.  Notecards 
automatically resize to fit the viewport() width dimensions (3 cards per row).
 
-       QItemSelectionModel* selections = selectionModel();
+       //QItemSelectionModel* selections = selectionModel();
        QStyleOptionViewItem styleViewOption = viewOptions();
 
        QStyle::State state = styleViewOption.state;

=== modified file 'src/frontends/qt4/CorkboardManager.cpp'
--- src/frontends/qt4/CorkboardManager.cpp      2010-05-24 14:09:18 +0000
+++ src/frontends/qt4/CorkboardManager.cpp      2010-05-25 16:35:12 +0000
@@ -42,7 +42,7 @@
 #include "FuncStatus.h"
 #include "FuncCode.h"
 #include "LyXAction.h"
-#include "Lyx.h"
+#include "LyX.h"
 #include "insets/InsetCommand.h"
 #include "insets/InsetRef.h"
 
@@ -86,7 +86,7 @@
 
        const lyx::docstring search = currentDocstring;
        //String initial numbers using RegExp
-       newString.remove(QRegExp("^[0-9\.]+"));
+       newString.remove(QRegExp("^[0-9\\.]+"));
        const lyx::docstring replace = lyx::qstring_to_ucs4(newString);
        lyx::docstring const data = lyx::replace2string(replace, search, true, 
true, true, true);