Jean-Marc Lasgouttes wrote:
This commit is obviously correct but Vincent reported something
strange with forwardInset(), in that this will jump over portion of
the document instead of merely poping out of the current inset. Or
maybe it is just that the method name is misleading? In this case, I
would rename it to nextInset().
Yes. I planned to take a look at this, but I cannot find the
discussion anymore. Where was it?
In the thread "[patch] Spellchecker Bugs"
Abdel.
--- Begin Message ---
On 05/12/2009 02:25, Vincent van Ravesteijn wrote:
This patch fixes a few things for spellchecking.
while (from.inMathed())
from.forwardInset();
This caused LyX to skip parts of a document between two math insets:
I'd say that this is a bug of forwardInset() then.
+ if (from == end)
+ break;
This is needed because if from is at the end of the document (which is
possible when leaving the Math Inset), LyX will crash later.
OK with your comment above.
+ if (from == to)
+ continue;
This is needed to get a correct count of the number of words. However,
the reported number of words seems to be pretty random.
Ditto
I'm not sure about this part:
+ while (from.inMathed()) {
+ from.pop_back();
+ from.pos()++;
+ }
As said above, I'd rather have forwardInset() fixed.
Thanks for looking at those bugs.
Abdel.
--- End Message ---
