Abdelrazak Younes ha scritto:
@@ -158,7 +181,6 @@
{
// FIXME: create a Dialog::returnFocus() or something instead
of this:
view_.setCurrentWorkArea(view_.currentMainWorkArea());
- // FIXME: This should be an LFUN.
Why do you remove this FIXME?
Because, AFAICR, this was a consequence of the original way FindAdv
used to work: a direct call from (the current) FindAndReplace.cpp to
(the current) src/lyxfind.cpp. This was fixed very soon by adding the
LFUN_WORD_FINDADV new LFUN, and exploiting it. Now, this line of code
is a call to FindAndReplace::findAndReplace(), which in turn
dispatched an LFUN. So I thought the FIXME note was old stuff that
could be removed. Was I wrong ?
A bit yes:
The "normal" workflow is that the GUI uses the LFUN_WORD_FINDADV and
that LFUN_WORD_FINDADV in turn uses findAndReplace().
I'm suspecting we're getting confused by the FindAndReplace class name,
which is probably a non-standard name. In fact, residing inside
frontends/qt4, I think its name should be "GuiFindAndReplace". Shouldn't
it ?
So, going back to the above FIXME, it was placed close to a call from
the GUI (from within button press handlers) to the GUI itself (generic
findAndReplace method that builds the LFUN collecting options from the
GUI checkboxes and dispatches it).
Is it ok to rename the class (and file) ?
T.
--
Tommaso Cucinotta, Computer Engineering PhD, Researcher
ReTiS Lab, Scuola Superiore Sant'Anna, Pisa, Italy
Tel +39 050 882 024, Fax +39 050 882 003
http://feanor.sssup.it/~tommaso
