Tommaso Cucinotta wrote:
Abdelrazak Younes ha scritto:
tomm...@lyx.org wrote:
Author: tommaso
Date: Fri Aug 21 18:51:07 2009
New Revision: 31179
URL: http://www.lyx.org/trac/changeset/31179
Log:
Advanced Search GUI enhancements (tooltips, navigation, shorter labels)
@@ -158,7 +181,6 @@
{
// FIXME: create a Dialog::returnFocus() or something instead
of this:
view_.setCurrentWorkArea(view_.currentMainWorkArea());
- // FIXME: This should be an LFUN.
Why do you remove this FIXME?
Because, AFAICR, this was a consequence of the original way FindAdv
used to work: a direct call from (the current) FindAndReplace.cpp to
(the current) src/lyxfind.cpp. This was fixed very soon by adding the
LFUN_WORD_FINDADV new LFUN, and exploiting it. Now, this line of code
is a call to FindAndReplace::findAndReplace(), which in turn
dispatched an LFUN. So I thought the FIXME note was old stuff that
could be removed. Was I wrong ?
A bit yes:
The "normal" workflow is that the GUI uses the LFUN_WORD_FINDADV and
that LFUN_WORD_FINDADV in turn uses findAndReplace().
Abdel.
